Skip to content

feat(auth): Implement UseUserAccessGroup for C++ iOS SDK #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jonsimantov
Copy link
Contributor

This commit implements the UseUserAccessGroup method in the Firebase C++ Auth SDK. This method is iOS-only and allows developers to specify a keychain access group for sharing authentication state across multiple apps from the same publisher.

  • Added the public API UseUserAccessGroup(const char* access_group) to firebase::auth::Auth.
  • Implemented the Objective-C wrapper in auth_ios.mm to call [FIRAuth useUserAccessGroup:error:].
  • Added stub implementations for Android and Desktop platforms that log a warning and return kAuthErrorNone.
  • Included comprehensive Doxygen comments for the new API in auth.h.

Description

Provide details of the change, and generalize the change in the PR title above.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

This commit implements the `UseUserAccessGroup` method in the Firebase C++ Auth SDK. This method is iOS-only and allows developers to specify a keychain access group for sharing authentication state across multiple apps from the same publisher.

- Added the public API `UseUserAccessGroup(const char* access_group)` to `firebase::auth::Auth`.
- Implemented the Objective-C wrapper in `auth_ios.mm` to call `[FIRAuth useUserAccessGroup:error:]`.
- Added stub implementations for Android and Desktop platforms that log a warning and return `kAuthErrorNone`.
- Included comprehensive Doxygen comments for the new API in `auth.h`.
/// @return `kAuthErrorNone` on success.
/// Returns `kAuthErrorKeychainError` if an error occurs while
/// accessing the keychain (iOS/tvOS only).
/// Returns `kAuthErrorUnimplemented` if called on a platform other
Copy link
Contributor Author

@jonsimantov jonsimantov Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual stub methods return kAuthErrorNone, please fix this comment.

Copy link
Contributor Author

@jonsimantov jonsimantov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a note to the upcoming release's release notes?

@firebase firebase locked and limited conversation to collaborators Jul 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant